search

notlmn / copy-as-markdown

🖱 Browser extension to copy hyperlinks, images, and selected text as Markdown with GFM support
MIT License
312 stars 45 forks source link

Convert relative links to absolute links #6

Closed notlmn closed 4 years ago

notlmn commented 4 years ago

From review: https://addons.mozilla.org/en-US/firefox/addon/cpy-as-md/reviews/1514624/

Relative links are rarely useful and the user has to convert them to absolute links anyway. (Except when copying as Markdown from GitHub rendered MD, but GH converts all relative links to absolute anyway).

Sample link: https://www.macports.org/install.php#help (last 2 paragraphs)

seamusdemora commented 4 years ago

Thanks for taking that on board & please let me know if I can do anything to help.

notlmn commented 4 years ago

I don't know when I'll be able to work on this, will try tonight.

The issue meanwhile is open for anyone to take and raise a PR and I'd be very happy to see that.

CodingApps commented 4 years ago

I'd like to assist with setting these to absolute links.

notlmn commented 4 years ago

Thanks for thinking of contributing to this @codingapps, you should be a able to set this repo locally, change the source code, and test if that works.

If you have any issues or questions, feel free to ping me (here or Twitter).

notlmn commented 4 years ago

@seamusdemora, this should be fixed now. Expect changes in extension in then next release.