Commands to implement for the rust-cktap lib

notmandatory / rust-cktap

Coinkite Tap Protocol implementation for use with SATSCARD™ and TAPSIGNER™ products

MIT License

22 stars 4 forks source link

Commands to implement for the rust-cktap lib #17

Open notmandatory opened 1 year ago

notmandatory commented 1 year ago

I propose we keep the lib commands low-level one to one with actual cktap protocol messages. This gives users maximum flexibility and keep dependencies to a minimum.

shared:

[x] status (CkTransport.to_cktap)
[x] read (Read trait)
[ ] derive
[x] certs (Certificate trait)
[x] new (TapSigner.init and SatsCard.new_slot)
[ ] nfc
[ ] sign
[x] wait (Authentication.wait)

satscard only:

[x] unseal (SatsCard.unseal)
[x] dump (SatsCard.dump)

tapsigner only:

[ ] change
[ ] xpub
[ ] backup

notmandatory commented 1 year ago

Should we create a New trait to move the impl from TapSigner.init and SatsCard.new_slot?