Discussing some recent changes.

DhanrajHira commented 4 years ago

I have recently made quite a lot of changes to the API, but I have not talked about any of them. I apologize for this, I am making this thread to discuss recent changes, what I changed and my rationale behind it.

Changes
- All the code that deals with downloading episodes has been shifted to the modules in utils package. See #27
- New classes namely Downloader, MultiThreadDownloader, ChunkDownloader, StatefulSegmentList, ChunkMerger, FFmpegMerger and ChunkRemover have been introduced.
- Concurrency is now achieved using threads instead of processes. Since our use case is I/O limited, threads are a better choice due to the lower overhead.
- The number of threads that are used for downloading can now be limited using the MultiThreadDownloader class.
- Single threaded downloads now show a progress bar. I plan to extend this to multi threaded downloads as well.
- Single threaded downloads can now be resumed using Kurisu I was unsure of where to put this so I made a separate repo for this. I will update this post with a link to that repo when I finish setting it up. (I have tested this and it works). Here is the link

All the new downloading changes are implemented using the download_using_downloader() method. The hope is that in the future we can simply rename this method to download() and remove the old download() method.

notmarek commented 4 years ago

Thank you for all your hard work and great contributions!

notmarek commented 4 years ago

Added progress bar to multi threaded downloads in https://github.com/veselysps/Sakurajima/commit/e06aeaafd312fb83277ab7badb19b86cd81f093b

DhanrajHira commented 4 years ago

I am glad to be of help :) On a side note, I built a small CLI to download animes using Sakurajima but I am unsure of what to name it, can you suggest me a good name. Also, I know this is silly but is this repo named after Mai Sakurajima from Bunny Girl Senpai?

notmarek commented 4 years ago

Yeah it is, it's also one of the subdomains aniwatch uses for their videos - https://sakurajima.awch.me https://emilia.awch.me https://kaguya.awch.me https://togame.awch.me https://stella.awch.me https://kurisu.awch.me https://revy.awch.me https://zerotwo.awch.me

DhanrajHira commented 4 years ago

We already have Sakurajima and Kurisu so maybe we should name the CLI Kaguya? Or maybe we should just name it "Sakurajima CLI"?

notmarek commented 4 years ago

Kaguya sounds good.

notmarek / Sakurajima

Discussing some recent changes. #29

Changes