notmatthancock / pylidc

An object relational mapping for the LIDC dataset using sqlalchemy.
https://pylidc.github.io
Other
105 stars 40 forks source link

Include sqlalchemy automatically as dependency #8

Closed WGierke closed 6 years ago

WGierke commented 6 years ago

Thanks for your very useful library! Would it make sense to automatically install sqlalchemy as well when pylidc is beeing installed? Update: when installing dependencies using pip install -r requirements.txt, one gets the error ModuleNotFoundError: No module named 'sqlalchemy' which isn't even resolved when putting sqlalchemy ahead of pylidc.

notmatthancock commented 6 years ago

Ok, thanks for pointing that out. I'm not sure why it stopped installing dependencies. I built the package as a universal wheel (rather than a source dist as previously), and it appears to work now after installing from pip on a fresh virtualenv (full disclosure: I know nearly nothing about python package distribution). Try it out, and let me know if it works for you.

WGierke commented 6 years ago

Yes, it seems to be fixed in version 0.1.8. Thanks a lot!