search

notmike101 / betterdiscord-google-fonts

Allows use of Google Fonts on Discord through a simple settings UI
Do What The F*ck You Want To Public License
9 stars 2 forks source link

[Bug] Plugin does not overwrite theme fonts #46

Closed DaVouz closed 2 years ago

DaVouz commented 2 years ago

plugin doesn't work. I am changing the fonts but nothing happens tried to delete it and re install it and even downloading older versions idk what is wrong with it

notmike101 commented 2 years ago

Are there any errors in the developer console?

Are you using the newest version?

Is the plugin enabled?

DaVouz commented 2 years ago

don't know how to check the first one 2nd and 3rd one answer is yes

notmike101 commented 2 years ago

@DaVouz To Enable DevTools go to BD settings > Developer Settings > DevTools and enable the option

Then press CTRL + SHIFT + I. A new window should pop up, head over to the Console tab and be sure you've scrolled all the way to the bottom.

Once you have this set up and open., go into settings and disable and reenable the plugin to see any new errors that appear with the plugin.

DaVouz commented 2 years ago

it doesn't seem to give me an error for the font plugin only one other plugin gives me error but for some reason it works

notmike101 commented 2 years ago

@DaVouz If you go into the settings of the plugin, are you able to change the font that is being used?

Have you tried disabling all other plugins except the Google Fonts plugin to see if the issue still exists?

DaVouz commented 2 years ago

i disabled everything but it didn't work i can select fonts it's just that it doesn't change the fonts whatever font i select

notmike101 commented 2 years ago

Are you using any themes?

In the developer log, when you change a font, do you see anything similar to this: [GoogleFonts] (2.0.11) Changing font to FontName?

DaVouz commented 2 years ago

well aparewell aparently when i use some themes the font plugin doesn't work is it the problem of the new font plugin or is it the theme's problem?

notmike101 commented 2 years ago

Which theme are you using? If possible, can you share the theme file as an attachment to your comment (Please don't share code in the comment?

Depending on how the theme is working, this plugin may not be compatible with it... There's only so much I can do via a plugin to overwrite theme specified fonts.

DaVouz commented 2 years ago

Spotify-Discord.theme.zip yeah sure this is the theme it's called spotify discord

notmike101 commented 2 years ago

The issue is that the theme you're using is setting the --font-primary variable that I'm using for the plugin.

https://capnkitten.github.io/BetterDiscord/Themes/Spotify-Discord/css/source.css

What I may need to do is make a custom variable for google fonts that's set everywhere. I'll be experimenting with this to find a resolution to this issue.

notmike101 commented 2 years ago

@DaVouz Just released v2.0.13. Please try that and let me know if it resolves the issue.

DaVouz commented 2 years ago

yes brother for sure that sure fixed thank you very much i appreciate it a lot