search

notnotnotswipez / MoreCompany

MIT License
58 stars 21 forks source link

[Conflict/Issue] a commit evidence shows the detail of conflict with MRAPI, when player disconnected the player model will not destroy #115

Open CoolLKKPS opened 1 week ago

CoolLKKPS commented 1 week ago

some part of this commit1b4bbd5 can break MRAPI to destroy the player model when player disconnected, this evidence is found by V2rtua1, so if im not wrong, MRAPI doesn't notice this change that MoreCompany already publicized that patch and tbh i know both side can easily fix this but for some reason the patch are already delayed for too long, so idk, i do perfer this bc MRAPI doesn't know or accidentally ignored this part, im sure someone ahead of me are report this issue in discord already, but i truthly don't know what happen that can takes so long.

CoolLKKPS commented 1 week ago

@BunyaPineTree i really do perfer u accidentally ignored this part, sorry for mention u again, u already have the issue ticket in ur repository @1A3Dev if i was right, this just bc a patch that publicized, i know im might should not mention u (bc that really dumb just bc this), but just in case something that might need ur help

1A3Dev commented 1 week ago

some part of this commit can break MRAPI to destroy the player model when player disconnected

Vanilla doesn't destroy models on disconnect and neither does MoreCompany. MoreCompany just sets the object as inactive for performance reasons then re-enables it when it's used again

CoolLKKPS commented 1 week ago

MoreCompany just sets the object as inactive for performance reasons then re-enables it when it's used again

yea that exactly as my friend says, so to fix this, just need MRAPI do RemovePlayerModelReplacement again when player disconnected, i don't really think that's hard... actually

CoolLKKPS commented 1 week ago

@1A3Dev but if i was right, that really doesn't help improve performance for MRAPI, bc MRAPI always need to destory the model anyway, right? so can u make a config option to disable this for compatibility?

CoolLKKPS commented 1 week ago

but bc only happen when user have MRAPI install, so the config name should related with MRAPI

1A3Dev commented 1 week ago

@1A3Dev but if i was right, that really doesn't help improve performance for MRAPI, bc MRAPI always need to destory the model anyway, right? so can u make a config option to disable this for compatibility?

No because that'd still cause performance issues, MC deactivates the entire player script not the model anyway

CoolLKKPS commented 1 week ago

okay, even i d like to know what can be happen