search

notnotnotswipez / MoreCompany

MIT License
58 stars 21 forks source link

[Issue/v68] TZP voice pitch not working #70

Open CoolLKKPS opened 7 months ago

CoolLKKPS commented 7 months ago

same as topic

1A3Dev commented 4 months ago

Fixed for 4 player lobbies in the recent update, over 4 would be a bit difficult to do

donedonedone278 commented 3 months ago

TZP voice change doesn’t work for me either on v56 with the most recent morecompany version and just two people in the lobby.

1A3Dev commented 3 months ago

TZP voice change doesn’t work for me either on v56 with the most recent morecompany version and just two people in the lobby.

It's not based on how many people are in the lobby, the actual player limit needs to be set to 4

donedonedone278 commented 3 months ago

Confirmed that setting crew size to 4 fixes tzp voice for me! Thank you.

DaXcess commented 2 months ago

https://github.com/notnotnotswipez/MoreCompany/blob/e0fe5d442ab529110ad564cbd002a1d11c130bf8/MoreCompany/AudioMixerPatches.cs#L38-L42

Any reason for this not using AudioSource.pitch just like the code that handles volume using AudioSource.volume?

https://github.com/notnotnotswipez/MoreCompany/blob/e0fe5d442ab529110ad564cbd002a1d11c130bf8/MoreCompany/AudioMixerPatches.cs#L25-L34

1A3Dev commented 2 months ago

The voice chat overrides the pitch as stated here https://placeholder-software.co.uk/dissonance/docs/Tutorials/Playback-Prefab.html#prefab-components

DaXcess commented 2 months ago

Ah I see, at that point you'd have to patch dissonance if you'd want to achieve the desired result. Not wanting to do that is understandable.

EDIT: I tried doing this just to see what would happen. The answer is: nothing. The reason Dissonance forces the pitch to be 1, is not because it wants to, but because changing the pitch literally has no effect.