search

notofonts / Noto-LatinGreekCyrillic

Latin, Greek and Cyrillic Noto fonts
Apache License 2.0
3 stars 1 forks source link

Question: NotoSans Italic Greek kerning now is somewhat different from the previous one. Is this expected? #10

Open marekjez86 opened 3 years ago

marekjez86 commented 3 years ago

I manually rebuilt all of the instances and VF fonts. I looked at the differences on multiple samples. The most comprehensive one is NotoSans-BlackItalic-fontdiff-androidtxt-el.pdf

While most of the Android UI text is shorter or the same with the new Greek some of them became longer. The longer sentences caused me to raise a question: NotoSans Italic Greek kerning now is somewhat different from the previous one. Is this expected?

Some samples (more can be found in the PDF - green line is the new Greek):

Screen Shot 2021-07-07 at 8 22 47 AM Screen Shot 2021-07-07 at 10 00 34 AM Screen Shot 2021-07-07 at 9 59 48 AM Screen Shot 2021-07-07 at 9 59 09 AM Screen Shot 2021-07-07 at 9 57 19 AM Screen Shot 2021-07-07 at 8 28 21 AM Screen Shot 2021-07-07 at 8 26 11 AM Screen Shot 2021-07-07 at 8 25 30 AM Screen Shot 2021-07-07 at 8 24 45 AM Screen Shot 2021-07-07 at 8 24 04 AM Screen Shot 2021-07-07 at 8 23 08 AM

@irenevl: is this expected? (old kerning was with the old version of Greek)

Note that while running a fontmake I encountered the following (it might or might not have anything to do with my samples): WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.Alpha found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.alpha found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.eta found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.Gamma found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.gamma found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.Iota found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.iota found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.iotadieresistonos found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.Kappa found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.omicron found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.Rho found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.sigma found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.Theta found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.uni1F02 found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern1.Upsilon found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.Alpha found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.alpha found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.epsilon found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.eta found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.gamma found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.iota found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.iotadieresistonos found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.rho found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.tau found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.Theta found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.uni1F02 found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.uni1F12 found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.uni1F22 found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.uni1F42 found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.Upsilon found in kerning rules. WARNING:glyphsLib.builder.builders.UFOBuilder:Non-existent glyph class public.kern2.upsilon found in kerning rules.

twardoch commented 3 years ago

The new kerning is suspicious. Some pairs that were tighter and looked fine now are oddly loose.

irenevlachou commented 3 years ago

Hi @marekjez86, that's definitely wrong kerning. I'll check the sources and get back to you.

irenevlachou commented 3 years ago

Hi @marekjez86 I just pushed an update. Kerning was somehow mixed up from old and new sources so I fixed it. I've also updated a few glyphs that looked too wide. Here are the details:

https://github.com/irenevl/noto-source/commit/279359ec0a19436f97cd4f8e6a3dcd6b0c254c3f 20210713 Greek WIP commit:

I'll check now the Display files.