notofonts / adlam

Noto Adlam
SIL Open Font License 1.1
2 stars 0 forks source link

Adlam should add nasalization mark #6

Closed sven-oly closed 4 years ago

sven-oly commented 5 years ago

Defect Report

Use this template for filing a defect report. For feature requests and other matters, you can use part of the template and delete what you don't need.

Title

Adlam should add nasalization mark U+1E94B

Font

Full file name, for example 'NotoSansAdlam*.ttf'.

Where the font came from, and when

Font Version

All

OS name and version

All

Application name and version

If the issue is observed using a specific app.

Issue

Unicode 12 added 1E94B 𞥋 ADLAM NASALIZATION MARK, which looks a lot like an apostrophe. It "indicates prenasalization of succeeding consonant letter", according to the standard, similar to what we'd represent in Latin letters with "nj" or "nd" at the start of a word. This should added to our font offering for this script. We should check with our Adlam friends regarding the expected shape.

  1. Steps to reproduce:
  2. Observed results: this code point is not in Noto Sans Adlam
  3. Expected results: this shape should be part of the font.
  4. Additional information Here's the proposal for this character: https://www.unicode.org/L2/L2018/18282r-adlam.pdf

Character data

Please include real character data to illustrate your issue-- Unicode codepoints are helpful. This makes it possible for developers who don't know the language or script to copy/paste the text to reproduce the issue.

Screenshot

If possible, include a screenshot or an image illustrating the issue. Annotations are also helpful.

Tools for reporting bugs

Useful tools for reporting bugs are available at: https://github.com/googlei18n/

Harfbuzz hb-view and hb-shape

These are part of the HarfBuzz distribution and can help isolate if an issue is in the app/OS, shaping engine, or font.

For example:

  hb-view --font-file {path to font} --text-file {path to text file} --output-file '{sample}.png'

Fontview

Fontdiff

r12a commented 4 years ago

Any progress on this? The nasalisation character 𞥋 U+1E94B ADLAM NASALIZATION MARK is used frequently in Adlam text.

Noto Sans Adlam New supports it, however there is a gap in the baseline. If it appears between two letters that would normally join, the nasalisation character should not break that join. (This was the reason the code point was added, rather than use other punctuation.)

Screenshot 2020-08-01 at 12 34 34

I just downloaded the latest v3 Noto Sans Adlam and Noto Sans Adlam Unjoined and though they now have glyphs for comma punctuation they still don't have a glyph for the nasalisation character.

Screenshot 2020-08-01 at 12 41 36

marekjez86 commented 4 years ago

@sven-oly @r12a : Please check https://github.com/googlefonts/noto-fonts/tree/master/unhinted/ttf or https://github.com/googlefonts/noto-fonts/tree/master/hinted/ttf ...

Screen Shot 2020-09-24 at 22 35 10

If you have any issues, please provide me with the text you are using..

r12a commented 4 years ago

@marekjez86 i'm still seeing the problem of the broken baseline in Noto Sans Adlam. See the text. (Select the font at lower left.)

Screenshot 2020-09-25 at 08 07 31

marekjez86 commented 4 years ago

Please try font in https://github.com/googlefonts/noto-fonts/tree/master/unhinted/ttf/NotoSansAdlam/NotoSansAdlam-Regular.ttf

On Fri, Sep 25, 2020 at 12:12 AM r12a notifications@github.com wrote:

@marekjez86 https://github.com/marekjez86 i'm still seeing the problem of the broken baseline in Noto Sans Adlam. See the text https://r12a.github.io/pickers/adlm/?text=%F0%9E%A4%91%F0%9E%A4%B5%F0%9E%A5%85%F0%9E%A4%A4%F0%9E%A4%A2%F0%9E%A4%A4%20%F0%9E%A4%BA%F0%9E%A4%A2%F0%9E%A4%A3%F0%9E%A4%A2%F0%9E%A4%B2%F0%9E%A4%A2%F0%9E%A4%A4%20%F0%9E%A4%8B%F0%9E%A4%B2%F0%9E%A5%86%F0%9E%A4%A2%F0%9E%A4%A5%F0%9E%A4%A2%20%F0%9E%A4%A2%F0%9E%A5%84%F0%9E%A4%A3%F0%9E%A4%AB%F0%9E%A5%85%F0%9E%A4%B6%F0%9E%A4%AD%20%F0%9E%A4%AC%F0%9E%A4%AE%F0%9E%A4%AC%20%F0%9E%A4%A8%F0%9E%A4%AE%F0%9E%A4%BC%F0%9E%A4%AD%D8%8C%20%F0%9E%A4%B2%F0%9E%A5%8B%F0%9E%A4%A3%F0%9E%A4%AD%F0%9E%A4%A5%F0%9E%A4%AF%F0%9E%A4%AD%F0%9E%A4%A3%F0%9E%A4%AD%20%F0%9E%A4%AB%20%F0%9E%A4%B6%F0%9E%A4%AD%F0%9E%A4%A6%F0%9E%A4%AD%F0%9E%A4%B2%F0%9E%A4%A2%F0%9E%A4%B2%F0%9E%A5%86%F0%9E%A4%A3%F0%9E%A4%AB%20%F0%9E%A4%BC%F0%9E%A4%AE%20%F0%9E%A4%A6%F0%9E%A4%A2%F0%9E%A4%B2%F0%9E%A5%86%F0%9E%A4%BA%F0%9E%A4%AB%20%F0%9E%A4%B8%F0%9E%A4%A2%F0%9E%A4%B3%F0%9E%A5%86%F0%9E%A4%AB%F0%9E%A5%85%F0%9E%A4%B6%F0%9E%A4%AD.%20%F0%9E%A4%89%F0%9E%A4%A9%F0%9E%A4%AB%20%F0%9E%A4%B2%F0%9E%A5%8B%F0%9E%A4%BA%F0%9E%A4%AE%F0%9E%A5%85%F0%9E%A4%A3%F0%9E%A4%AD%20%F0%9E%A4%A5%F0%9E%A4%AD%F0%9E%A5%85%F0%9E%A4%B6%F0%9E%A4%AE%20%F0%9E%A4%AB%20%F0%9E%A4%B8%F0%9E%A4%A2%F0%9E%A4%B3%F0%9E%A5%86%F0%9E%A4%AD%F0%9E%A4%A4%F0%9E%A4%A2%F0%9E%A4%B2%F0%9E%A4%BC%F0%9E%A4%A2%F0%9E%A5%84%F0%9E%A4%BA%F0%9E%A4%A2%F0%9E%A4%A4%20%F0%9E%A4%AB%F0%9E%A4%BC%F0%9E%A4%AB%20%F0%9E%A4%AB%F0%9E%A4%A9%F0%9E%A4%AB%20%F0%9E%A4%A8%F0%9E%A4%AE%F0%9E%A4%BC%F0%9E%A4%AD%20%F0%9E%A4%B8%F0%9E%A4%B5%F0%9E%A5%85%F0%9E%A4%AC%F0%9E%A4%AE%20%F0%9E%A4%B2%F0%9E%A5%8B%F0%9E%A4%A3%F0%9E%A4%AD%F0%9E%A4%AA%F0%9E%A4%A3%F0%9E%A4%AB%20%F0%9E%A4%AB%20%F0%9E%A4%B2%F0%9E%A5%8B%F0%9E%A4%A3%F0%9E%A4%AB%F0%9E%A4%AA%20%F0%9E%A4%A9%20%F0%9E%A4%AD%F0%9E%A4%B4%F0%9E%A4%B2%F0%9E%A4%BA%F0%9E%A4%B5%F0%9E%A4%B4%F0%9E%A4%B5%F0%9E%A4%A5%F0%9E%A5%86%F0%9E%A4%A2%F0%9E%A5%84%F0%9E%A4%BA%F0%9E%A4%B5.. (Select the font at lower left.)

[image: Screenshot 2020-09-25 at 08 07 31] https://user-images.githubusercontent.com/4839211/94237355-a4eb6b80-ff06-11ea-9d3c-cfdd5c4167f8.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/googlefonts/noto-fonts/issues/1501#issuecomment-698764483, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFUS727U55XURJEA7W4MUTSHQ7FXANCNFSM4HKDWGFA .

r12a commented 4 years ago

Same result, @marekjez86 . For clarity, i just installed and tested Version 3.000 on Mac OS X 10.14.6 using up to date versions of Firefox and Chrome. The previous test used the hinted version.