notofonts / bengali

Noto Bengali
SIL Open Font License 1.1
2 stars 1 forks source link

Bengali and Devanagari: Adjust usWinAscent in OS/2 table #12

Closed brawer closed 2 years ago

brawer commented 8 years ago

From @lemzwerg via e-mail: GDI hinting [of NotoSansBengali], as shown e.g. on this page, gets clipped at the top. This could be fine-tuned with ttfautohint options, but I think it would be better to adjust NotoSansBengali's value of usWinAscent in the OS/2 table – if you look at this image you can see that even with manual hinting the top gets cut off also at 9px. The same happens for NotoSansDevanagari, BTW.

marekjez86 commented 8 years ago

@lemzwerg we just received delivery of Noto SERIF {Bengali,Devanagari}. Could you check if this is an issue there also if I provided you with the fonts (hinted?unhinted?)?

Thanks

lemzwerg commented 8 years ago

I've checked the NotoSerifBengali fonts (as currently available in the repository), and they seem OK. As soon as the NotoSerifDevanagari fonts are checked in, I will test them, too.

JelleBosmaMT commented 7 years ago

As part of the delivery of Noto Sans Bengali MM I have been asked to comment on open issues: The clipping is result of a cvt delta trying to make 9 ppm slightly more legible by adding a pixel to the ascend. To fix this, adjusting WinAscend is not a particular good idea. Improving our careful manual hinting by tweaking ttfautohint parameters would be counter productive. The proper solution would have been to add a VDMX table with an entry for 9 ppem and 9 ppm only. Of course 9 ppm Devanagari is not a size recommended for actual reading, more to give an impression of text. So I don't think this clipping issue has any practical consequences.

For Chrome OS, the platform for which the hinting was done, I was led to believe clipping was not an issue. But I haven't tested this.

nizarsq commented 4 years ago

Is this issue still reproducible? I see @marekjez86 mentioned new NotoSerifBengali build.

simoncozens commented 2 years ago

I'm not convinced this is still a bug, and we no longer appear to be using the manual hints anyway.