notofonts / bengali

Noto Bengali
SIL Open Font License 1.1
2 stars 1 forks source link

Noto Serif Bengali has incorrect AGLFN names #4

Closed devosb closed 1 year ago

devosb commented 4 years ago

Font

NotoSerifBengali-Regular.ttf.

Where the font came from, and when

Site: https://github.com/googlefonts/noto-fonts/blob/master/phaseIII_only/hinted/ttf/NotoSerifBengali/NotoSerifBengali-Regular.ttf Date: 2019-12-09

Font Version

2.000

OS name and version

Ubuntu Bionic amd64 is what I am running, but the issue is the names of the glyphs in the TTF, so I don't think which OS will have an affect.

Issue

The source for this font has friendly names such as k_tt_ra-beng. When the TTF is built, this glyph gets the name uni099509CD099709CD09B0, but it should be uni099509CD099F09CD09B0.

  1. Steps to reproduce View TTF in some font viewer program.
  2. Observed results uni099509CD099709CD09B0 for k_tt_ra-beng
  3. Expected results uni099509CD099F09CD09B0 for k_tt_ra-beng
  4. Additional information The full list of issues I found is
    <key>public.postscriptNames</key>
    <dict>
     <key>k_tt_ra-beng</key>
    -    <string>uni099509CD099709CD09B0</string>
    +    <string>uni099509CD099F09CD09B0</string>
     <key>k_tta_iMatra-beng</key>
    -    <string>uni099509CD099509BF</string>
    +    <string>uni099509CD099F09BF</string>
     <key>l_pa-beng</key>
    -    <string>uni09B209CD09A9</string>
    +    <string>uni09B209CD09AA</string>
     <key>m_pa-beng</key>
    -    <string>uni09AE09CD09A9</string>
    +    <string>uni09AE09CD09AA</string>
     <key>n_tt_iMatra-beng</key>
    -    <string>uni09A809CD099F09BF</string>
    +    <string>uni09A809CD099F09CD09BF</string>
     <key>p_pa-beng</key>
    -    <string>uni09AA09CD09A9</string>
    +    <string>uni09AA09CD09AA</string>
     <key>s_pa-beng</key>
    -    <string>uni09B809CD09A9</string>
    +    <string>uni09B809CD09AA</string>
     <key>s_tta-beng</key>
    -    <string>uni09B809CD0997</string>
    +    <string>uni09B809CD099F</string>
     <key>ss_pa-beng</key>
    -    <string>uni09B709CD09A9</string>
    +    <string>uni09B709CD09AA</string>
     <key>ss_tta-beng</key>
    -    <string>uni09B709CD0997</string>
    +    <string>uni09B709CD099F</string>
     <key>ss_tta_iMatra-beng</key>
    -    <string>uni09B709CD099509BF</string>
    +    <string>uni09B709CD099F09BF</string>
    </dict>

    The GlyphsApp source file for this font was converted to UFO, so a derivative found could be produced. The above diff is from the diff between the original and fixed files of lib.plist in the UFO.

Note that some of the incorrect AGLFN names reference U+09A9, which is not an assigned character in Unicode.

simoncozens commented 1 year ago

I think this is now fixed!

$ shape variable_ttf/NotoSerifBengali-VF.ttf -u 0995,09CD,099F,09CD,09B0
[uni099509CD099F09CD09B0=0+605]