markhdavid
commented
4 months ago As stated, I generated test images for every weight of all three families and verified correct output. However, I'll just present here image files corresponding to the two hb-view commands shown in issue #39, only slightly modified in that the --text-file argument is for a new file that does not contain any non-Hebrew characters other than vertical bar (|), since the generated .ttf's apparently lack all non-Hebrew characters, so they would just show up as fallback characters.
This is the modified --text-file:
test-all-yiddish-ligatures-bars.txt
These are the modified commands:
hb-view --font-file NotoSansHebrew-Regular.ttf --text-file test-all-yiddish-ligatures-bars.txt --output-file "sans-ligatures.png" hb-view --font-file NotoRashiHebrew-Regular.ttf --text-file test-all-yiddish-ligatures-bars.txt --output-file "rashi-ligatures.png"
These are the resulting image files:
Sans: correct:
Rashi: correct:
simoncozens
Sans
Layers adjusted:
double-vav: regular, semibold, bold, light condensed, condensed, semibold condensed, bold condensed
Weights corrected:
Black, ExtraCondensed-Black, Bold, ExtraCondensed-Bold, ExtraBold, ExtraCondensed-ExtraBold, ExtraLight, ExtraCondensed-ExtraLight, Light, ExtraCondensed-Light, Medium, ExtraCondensed-Medium, Regular, ExtraCondensed-Regular, SemiBold, ExtraCondensed-SemiBold, ExtraCondensed-Thin, Condensed-Black, SemiCondensed-Black, Condensed-Bold, SemiCondensed-Bold, Condensed-ExtraBold, SemiCondensed-ExtraBold, Condensed-ExtraLight, SemiCondensed-ExtraLight, Condensed-Light, SemiCondensed-Light, Condensed-Medium, SemiCondensed-Medium, Condensed-Regular, SemiCondensed-Regular, Condensed-SemiBold, SemiCondensed-SemiBold, Condensed-Thin, SemiCondensed-Thin
(i.e., every weight except Thin)
Rashi
Layers adjusted:
double-vav: light, regular
vav-yod: light, regular
double-yod: light
Weights corrected:
Bold, ExtraBold, ExtraLight, Light, Medium, Regular, SemiBold, Thin
(i.e., every weight except Black)
Tested by regenerating ttf's via Glyphs App > File > Export, then running hb-view commands as per issue, but extended to test for every weight of .ttf font generated for all 3 families (Sans/Rashi/Serif). After fixes, generated .png files show good alignment in all weights of all 3 families.