notofonts / hebrew

Noto Hebrew
SIL Open Font License 1.1
2 stars 1 forks source link

Correct bottom anchor x position for vav-vav/yod-yod digraphs (#38) #43

Closed markhdavid closed 7 months ago

markhdavid commented 7 months ago

For all three families (Sans, Serif, Rashi) and across all layers, this commit adds the "bottom" anchor at the correct x position for double-yod and corrects it for double-vav. The adjustment ensures the x position is now accurately placed halfway between the bottom anchor's x position on each of the subletters, with the Y position at 0 (baseline).

Tested by regenerating TTFs via the Glyphs App (File > Export) for each family, then running hb-view commands ala instructions in issue, but extended test to every weight generated for all 3 families (Sans/Rashi/Serif). Then visually inspected every resulting .png file, confirming the corrections were successful and visually consistent across all variants.

markhdavid commented 7 months ago

Here is a sampling of tested families/weights, specifically those that had been shown in the Screenshot section of issue #38, showing correct anchor x position for the digraphs:

Sans Thin: NotoSansHebrew-Thin ttf-digraphs

Sans Extra Light: NotoSansHebrew-ExtraLight ttf-digraphs

Sans Light: NotoSansHebrew-Light ttf-digraphs

Rashi Regular: NotoRashiHebrew-Regular ttf-digraphs

simoncozens commented 7 months ago

Thank you very much, looks good to me!