notofonts / hebrew

Noto Hebrew
SIL Open Font License 1.1
2 stars 1 forks source link

Dagesh overlaps in heavier weights of Noto Sans Hebrew #47

Open MAZ06 opened 6 months ago

MAZ06 commented 6 months ago

Font

NotoSansHebrew[wdth,wght].ttf

Where the font came from, and when

https://github.com/notofonts/hebrew/releases/tag/NotoSansHebrew-v2.003

Font Version

Noto Sans Hebrew 2.003

OS name and version

Windows 11

Application name and version

Photoshop

Issue

The dagesh can sometimes overlap the next letter in the heavier weights as seen in the screenshots below. This seems to affect Black, SemiCondensed Black, Condensed Black, ExtraCondensed Black, Condensed ExtraBold, and ExtraCondensed ExtraBold.

Character data

יּה U+05D9 י U+05BC ּ U+05D4 ה

Screenshot

image Left: Black, SemiCondensed Black, Condensed Black, ExtraCondensed Black Right: Condensed ExtraBold, ExtraCondensed ExtraBold

image

MAZ06 commented 5 months ago

@simoncozens It seems that this is not fully fixed.

The יּה works now, but יּע still does not. image image

MAZ06 commented 5 months ago

These too: וּש וּג וּט וּך וּכ וּס וּף וּפ וּץ image image image image image image image image image יּע יּש יּג יּט יּכ יּס יּפ יּץ image

MAZ06 commented 5 months ago

And then these are cutting it pretty close: וּם וּמ וּח וּה וּת וּר וּנ וּן יּד image image

MAZ06 commented 5 months ago

Almost every letter combination with yod and vav would have to have its own dagesh form if you're going to do it the way I saw in your code.

simoncozens commented 5 months ago

I don't think I'm doing it the way you think I'm doing it. :-)

The dagesh combines with the yod/vav to make a "dagesh form", not the letter after it. We just need a bit of kerning on those two glyphs.

MAZ06 commented 5 months ago

Apologies. I'm obviously not much of a coder. But thanks for reopening this issue.

MAZ06 commented 4 months ago

I retested all of these with the new Sans font: image

Looks mostly fixed but a few are either still overlapping or cutting it pretty close: וּס image וּפ image יּכ image