notofonts / hebrew

Noto Hebrew
SIL Open Font License 1.1
2 stars 1 forks source link

Backwards discretionary ligature of yod and vav #5

Closed dscorbett closed 2 years ago

dscorbett commented 6 years ago

Font

NotoSansHebrew-Regular.ttf NotoSerifHebrew-Regular.ttf

Where the font came from, and when

Site: https://noto-website-2.storage.googleapis.com/pkgs/NotoSansHebrew-unhinted.zip Site: https://noto-website-2.storage.googleapis.com/pkgs/NotoSerifHebrew-unhinted.zip Date: 2018-03-04

Font version

Version 2.000;GOOG;noto-source:20170915:90ef993387c0

Issue

'dlig' applied to yod and vav produces a sequence of vav and yod.

Character data

יו U+05D9 HEBREW LETTER YOD U+05D5 HEBREW LETTER VAV

Screenshot

יויו

dscorbett commented 4 years ago

This bug is also present in Noto Rashi Hebrew. יו

nizarsq commented 3 years ago

This issue seem to be fixed. @dscorbett any opinion?

Screen Shot 2020-08-04 at 3 18 10 PM
dscorbett commented 3 years ago

Did you enable 'dlig' for that test?

nizarsq commented 3 years ago

Yes tested when dlig is enabled and disabled. Attached screenshot is for enabled dlig.

Screen Shot 2020-08-04 at 4 37 02 PM
dscorbett commented 3 years ago

That test does not enable 'dlig' correctly. The CSS declaration is font-font-feature-settings: dlig but it should be font-feature-settings: 'dlig'.

nizarsq commented 3 years ago

That test does not enable 'dlig' correctly. The CSS declaration is font-font-feature-settings: dlig but it should be font-feature-settings: 'dlig'.

Thanks, I already updated the code.

nizarsq commented 3 years ago
Screen Shot 2020-08-04 at 7 05 18 PM Screen Shot 2020-08-04 at 7 06 00 PM
dscorbett commented 3 years ago

The CSS declaration is still wrong. It should be font-feature-settings: 'dlig'.

nizarsq commented 3 years ago

The CSS declaration is still wrong. It should be font-feature-settings: 'dlig'.

My bad. I didn't see that I typed in "font-" twice. And copied for each font. I'll update the bug with correct version.

nizarsq commented 3 years ago
Screen Shot 2020-08-04 at 9 25 24 PM
kosmynkab commented 3 years ago

The order in the feature code was wrong - it was automatically generated for the vavyod-hb ligature as sub yod-hb vav-hb instead of other way around. Resolved across all Noto Sans, Serif and Rashi versions (will be pushed in the collective update of multiple issue resolution).