search

notofonts / noto-cjk

Noto CJK fonts
http://www.google.com/get/noto/help/cjk
2.94k stars 215 forks source link

No Super OTC found in Noto Sans CJK v2.004 #261

Closed muzimuzhi closed 9 months ago

muzimuzhi commented 9 months ago

Is your feature request related to a problem? Please describe.

There's no Super OTC asset in Noto Sans CJK v2.004 release, though the release title contains phrase "Super OTC" and download guide provides description and download link for it, which directs to raw file on default branch.

Describe the solution you'd like

If it's possible to update that release, provide Sans Super OTC as an asset, so it can be downloaded through a typical GitHub release asset url.

The question is which number it should use. Serif Super OTC is numbered 01, see 01_NotoSerifCJK.ttc.zip in Noto Serif CJK v2.002 release. To not alter names of any existing Serif2.004 assets, possible choices for Sans Super OTC asset are 00_NotoSansCJK.ttc.zip or 21_NotoSansCJK.ttc.zip.

Describe alternatives you've considered

Keep the list of assets in that stable release intact and only provide Sans Super OTC in next release. Then release description may need a note.

Additional context

Sans Super OTC zip file is contained in current repo, at corresponding tag Sans2.004: https://github.com/notofonts/noto-cjk/blob/Sans2.004/Sans/SuperOTC/NotoSansCJK.ttc.zip

muzimuzhi commented 9 months ago

Compared to release script for Noto Serif CJK, looks like Sans Super OTC is missing in the release script for Sans.

https://github.com/notofonts/noto-cjk/blob/727f898acdf7b100d308af8edf63c3953b626a1b/gh-release-noto-cjk-sans.sh#L34-L36

https://github.com/notofonts/noto-cjk/blob/727f898acdf7b100d308af8edf63c3953b626a1b/gh-release-noto-cjk-serif.sh#L29-L35

punchcutter commented 9 months ago

I guess I mistakenly skipped it in the release script for Sans. Adding it at the beginning would be good, but end or beginning wouldn't be totally consistent with Serif either way. I didn't want to put those numbers in the file names, but without them the release is sorted in a messy way. I guess I can add it as 00_NotoSansCJK.ttc.zip to keep the order closer to Serif.

punchcutter commented 9 months ago

Added to the release at https://github.com/notofonts/noto-cjk/releases/download/Sans2.004/00_NotoSansCJK.ttc.zip I will update the release script to match.

muzimuzhi commented 9 months ago

Many thanks!

muzimuzhi commented 9 months ago

I guess I can add it as 00_NotoSansCJK.ttc.zip to keep the order closer to Serif.

I will update the release script to match.

Will NotoSansCJK.ttc.zip numbered 01 in updated script hence in future releases, or it will stick to 00?

punchcutter commented 9 months ago

I think it's best to keep it at 00 so that any future releases are consistent.

muzimuzhi commented 9 months ago

That's great. That way I'll be brave enough to use Sans asset urls in Homebrew font casks, like how Serif ones are used (https://github.com/Homebrew/homebrew-cask-fonts/pull/8720#issuecomment-1831417884).