notofonts / noto-fonts

Noto fonts, except for CJK and emoji
http://fonts.google.com/noto
SIL Open Font License 1.1
2.46k stars 199 forks source link

Italic bits not set for Noto Sans Italic and BoldItalic #2269

Closed ollimeier closed 2 years ago

ollimeier commented 2 years ago

Title

Italic bits not set for Noto Sans Italic and Bold Italic

Font

NotoSans-BoldItalic.ttf NotoSans-Italic.ttf

Where the font came from, and when

https://github.com/googlefonts/noto-fonts/tree/main/hinted/ttf/NotoSans Date: 2022-03-03 (preferred format)

Font Version

2.007

Issue

The Italic bits are not set in:

ollimeier commented 2 years ago

This results in fake Bold and Italics fake-bold fake-italics

:

simoncozens commented 2 years ago

Traced back to glyphsLib doing this:

<instance name="Noto Sans Italic"
  familyname="Noto Sans"
  stylename="Italic"
  filename="../instance_ufo/NotoSans-Italic.ufo"
  stylemapfamilyname="Noto Sans Italic"
  stylemapstylename="regular">

(Bogus stylemap family name / style name.) Now to work out why glyphsLib is doing that for this font in particular...

simoncozens commented 2 years ago

Found it, it's in the style linking flags. PR soon.

ollimeier commented 2 years ago

@simoncozens Thank you very much for having a look into it. I much appreciate you fast contribution. May I ask you, when there will be new fixed fonts available?

marekjez86 commented 2 years ago

soon on GitHub noto-fonts; within the next few days

Other distribution points will take longer

On Fri, Mar 4, 2022 at 06:24 Olli Meier @.***> wrote:

@simoncozens https://github.com/simoncozens Thank you very much for having a look into it. I much appreciate you fast contribution. May I ask you, when there will be new fixed fonts available?

— Reply to this email directly, view it on GitHub https://github.com/googlefonts/noto-fonts/issues/2269#issuecomment-1059206180, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFUS7ZFRSHVTZEWQJAZSKLU6IMJNANCNFSM5PZ3IC4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you modified the open/close state.Message ID: @.***>

ollimeier commented 2 years ago

Awesome. Thank you very much.

xctvcd commented 2 years ago

Hi @marekjez86, thanks for the quick fix, there’s an issue left, see notofonts/latin-greek-cyrillic#384. Cheers!

simoncozens commented 2 years ago

I will take a look at that next week.