notofonts / noto-source

Apache License 2.0
582 stars 89 forks source link

Fix NotoSansOriya-MM.glyphs GSUB,GDEF #607

Closed KazunariTsuboi closed 2 years ago

KazunariTsuboi commented 2 years ago

The work I did was to fix GSUB and GDEF to use glyphs that already existed in the font but weren't used. No modifications have been made to the glyph design or anchors.

I also added a test that uses fontdiff. The result of the test is as follows. I sought to minimize the impact on strings that already exist. image

The issues I have modified and the details of the modifications are as follows.

Fixes googlefonts/noto-fonts#2380

Cause: ■ pres

■ blws

Measures: ■ pres

■ blws

Fixes googlefonts/noto-fonts#2381

Cause -Not included in the GDEF Markclass

Measures -Fixed glyph properties in Glyphs App. Script to oriya, category to Mark, subcategory to Nospacing.

Fixes googlefonts/noto-fonts#2382

Cause ■ psts, abvs

Measures

Fixes googlefonts/noto-fonts#2383

Measures

simoncozens commented 2 years ago

This is brilliant, thank you! @marekjez86, before we merge this I would like to add a few commits (bump version/copyright, add fontbakery shaping tests, check GF specs)

marekjez86 commented 2 years ago

@KazunariTsuboi : thank you! great result @simoncozens : waiting for bump version/copyright, add fontbakery shaping tests, check GF specs