search

notofonts / old-hungarian

Noto Old Hungarian
SIL Open Font License 1.1
3 stars 1 forks source link

Added capital ligatures #20

Closed kovacshviktor closed 5 months ago

kovacshviktor commented 5 months ago

On branch add_capital_ligatures Changes to be committed: modified: documentation/NotoSansOldHungarian.article.html modified: sources/NotoSansOldHungarian.glyphs

kovacshviktor commented 5 months ago

This MR adds the uppercase ligatures that were missing in the previous implementation. It brings the upper and lower case letters to a baseline. The electronic library of the National Széchenyi Library has ~50 books with single-baseline text. (https://mek.oszk.hu/) Rovas-info is the only publisher that aligns letters to the centerline (~10 books) This MR does not include the accented display, which appears in correspondence of 2-3 people only in the 20th century. The alphabet of the latter uses several incorrect letters ("Y" shaped B, "triangle" shaped O...) This MR resolves #15 and #16 issues Issues #1 and #2 do not belong to this repo. This MR optimises the use of ligatures in such a way that only consonant + vowel ligatures are included in the discrete ligatures, otherwise the automatism may render the text unreadable. The ligatures "JI", "VV", "KV" and "KSZ" are not included in the discrete ligatures either, because they are reserved for "Y", "W", "Qu" and "X".

kovacshviktor commented 5 months ago

@simoncozens Plesae merge this MR!

kovacshviktor commented 5 months ago

@simoncozens I did not redraw the whole font, my font designer just saved the glyphs file in a different structure.

kovacshviktor commented 5 months ago

@simoncozens The submission 21-115 to Unicode was not accepted building on the following submissions: 22-285 , 23-067 24-003 . The decision-makers are Michael Everson and André Szabolcs Szelp.

kovacshviktor commented 5 months ago

@simoncozens What does it mean "add more commits"? I need to add more ligatures?

kovacshviktor commented 5 months ago

@simoncozens It publicable, I think.

simoncozens commented 5 months ago

Strange to change the article just to add ligatures, no?

kovacshviktor commented 5 months ago

Strange to change the article just to add ligatures, no?

The On the main discussion page, which has been frozen, was the need for ligatures in capital letters. There was also a request to align the upper and lower case letters to a baseline. What I added was to optimize the ligatures according to our experience.

simoncozens commented 5 months ago

This PR also:

I don't know whether adding all these ligatures is a good idea or not - but I can't accept this PR as it stands because of what it does to the rest of the source file.

kovacshviktor commented 5 months ago

This PR also:

  • Adds a change to the article.
  • Changes the font family name from Noto Sans Old Hungarian to Noto Sans Old Hungarian Regular. "Regular" does not belong in the family name.

It's my fault.

  • Changes all the glyph outlines to use quadratic curves. Font sources should use cubic curves.

Sorry, fonforge changed it.

  • Changed the size of the numerals.

Yes. The Rovas Foundation's request was also on the original discussion paper.

  • The kerning of the new ligatures is written in feature code, rather than in the font's kerning source tables.

Sorry, I used the FontForge. I am not a perfect developer. I wanted to resolve this quickly.

I don't know whether adding all these ligatures is a good idea or not - but I can't accept this PR as it stands because of what it does to the rest of the source file.

All right, I'll try to ask someone to prepare it.

kovacshviktor commented 5 months ago

@simoncozens I'll work with it.

kovacshviktor commented 5 months ago

@simoncozens Leave the usability experience to us. We are Hungarians, we can better see what needs to be touched, (in discrete describing) what does not. I close this PR.