search

notofonts / tai-tham

Noto Tai Tham
SIL Open Font License 1.1
1 stars 0 forks source link

Tai Le: Combining diacritics are missing from the font #9

Closed marekjez86 closed 8 years ago

marekjez86 commented 9 years ago

moved from https://github.com/googlei18n/noto-alpha/issues/243

Imported from Google Code issue notofonts/notobuilder#24 created by roozbeh@google.com on 2014-06-14T01:33:00.000Z:

The traditional Tai Le orthography uses the following five combining characters as tone marks, but they are missing from the Noto Sans Tai Le font: U+0300, U+0301, U+0307, U+0308, and U+030C.

GPOS and GSUB information should also be added to the font to position the characters properly. Also note that the Unicode standard specifies that "When one of the combining diacritics follows a tall letter [...], it is displayed to the right of the letter, [...]" basically becoming spacing.

See http://www.unicode.org/L2/L2001/01369-n2372.pdf and section 11.5 of Unicode Standard version 6.2 (http://www.unicode.org/versions/Unicode6.2.0/ch11.pdf).

jungshik commented 9 years ago

/cc @kmansourMT

googlei18n/nototools#62 deals with a lint tool addition for checking this.

dougfelt commented 8 years ago

The current version is 1.03. The diacritics are in the font and position ok over ka: taile

They also position to the right of tall letters. However, they seem to swallow (overhang?) the spaces that follow them (each of these except the last is followed by space): taile2

The referenced document (and the bug report) mention that combining diacritics should become spacing marks "Typographically, when one of the combining diacritics follows a tall letter, it is represented as a spacing mark." (http://www.unicode.org/L2/L2001/01369-n2372.pdf) but it seems the generated mark is not spacing: taile4

Notice how in each case (except the last, where there is no following consonant) the mark overhangs the following consonant ka, instead of turning into a spacing mark.

So this is not yet fixed.

kmansourMT commented 8 years ago

Please point us to your font data and text files. Thanks.

kmansourMT commented 8 years ago

I've run some tests to verify the reported errors and have found the following. The attached test file (TaiLe-test-03xx.txt) was rendered through 3 separate OT interpreters: Harfbuzz, Uniscribe (thru Babelpad), and Monotype's PFC. The shaper output from Harfbuzz indicates that the spacing versions of the marks have been selected, but the PDF shows the marks overlaying the successive base character. Both BabelPad and PFC correctly show spacing marks in their rendering. See attached files.

taile-test-03xx-pfc taile-test-03xx-babelpad

kmansourMT commented 8 years ago

taile-test-03xx-hb

dougfelt commented 8 years ago

I was using hb-view to generate the images that I posted, so perhaps there is a HarfBuzz issue. @behdad?

behdad commented 8 years ago

@jfkthame. Do you have any suggestions here? The issue seem to be that for Tai Le and many other scripts, if we don't send them through USE shaper, they go through default, which has HB_OT_SHAPE_ZERO_WIDTH_MARKS_DEFAULT, which is to zero mark advances.

behdad commented 8 years ago

I can add a version of default shaper that doesn't zero marks, but not clear to me which scripts should go through it. Perhaps those that Uniscribe implements?

marekjez86 commented 8 years ago

I'm not sure if this should be assigned to waksmonskiMT at this point.

dougfelt commented 8 years ago

Not sure why @behdad didn't take it, but I agree it doesn't seem like an MTI issue.

kmansourMT commented 8 years ago

I would like to reiterate that the spacing versions of the combining marks u0300, u0301, u0307, u0308, and u030C are not classified as marks, but as bases. In the contexts where a tall vowel interferes with the placement of combining marks, we explicitly substitute the non-spacing mark with a spacing base glyph. There is therefore good reason to believe that this is a HarfBuzz error.

From: Marek Jeziorek notifications@github.com<mailto:notifications@github.com> Reply-To: googlei18n/noto-fonts reply@reply.github.com<mailto:reply@reply.github.com> Date: Friday, 23 October 2015 at 15:42 To: googlei18n/noto-fonts noto-fonts@noreply.github.com<mailto:noto-fonts@noreply.github.com> Cc: Kamal Mansour kamal.mansour@monotype.com<mailto:kamal.mansour@monotype.com> Subject: Re: [noto-fonts] Tai Le: Combining diacritics are missing from the font (#472)

I'm not sure if this should be assigned to waksmonskiMT at this point.

— Reply to this email directly or view it on GitHubhttps://github.com/googlei18n/noto-fonts/issues/472#issuecomment-150709485.

behdad commented 8 years ago

This should be fixed in HarfBuzz master. Release will come in a few days.