notpike / The-Fonz

TouchTunes Wireless Remote Sniffer/Transmitter for the Yard Stick One
Other
168 stars 24 forks source link

NEC encoding explanation wrong? #12

Open jinschoi opened 2 years ago

jinschoi commented 2 years ago

Hi. I'm comparing your implementation against a captured bitstream and finding a discrepancy with your documentation.

According to this doc, the command is doubled with its logical inverse (bit flipped version), where you have it as simply reversed: 0x32 -> 0x3223. It should be 0x32cd. Your example encode is correct because the logical inverse of 0x78 is 0x87.

Actually, I just checked the code and it is implemented correctly! So it just the explanation that needs to be updated.