search

notrab / dumbo

A lightweight, friendly PHP framework for HTTP.
MIT License
158 stars 16 forks source link

Add `logger` middleware helper #32

Closed lucasacoutinho closed 2 months ago

lucasacoutinho commented 2 months ago

This PR add the feature:

fixes #29

-- I noticed that logs were getting duplicated when using nested or grouped routes, so I used array_unique(..., SORT_REGULAR) to resolve the issue. However, this approach could cause problems if a middleware genuinely needs to be applied more than once, so it would require further testing.

I really enjoyed using Hono on a work project, and having something similar in PHP is fantastic. Thank you for creating this project!

notrab commented 2 months ago

This looks epic! I'll test it out fully tomorrow and merge. 🔥🚀🚀

notrab commented 2 months ago

@lucasacoutinho I've gone ahead and merged this. It all worked fine!

Let's keep an eye on the SORT_REGULAR caveat and see if we need to make further changes.

I love the middleware approach we're taking with this framework. Sensible defaults and simple middleware extensions!