notrab / headless-dropshipping-starter

Create your own dropshipping store with Next.js, Snipcart & Printful 👕
https://headlessdropshipping.com
693 stars 132 forks source link

Tax calculation #85

Open moxley01 opened 1 year ago

moxley01 commented 1 year ago

Hey there,

In the /api/snipcart/tax endpoint there is a line which goes

if (eventName !== "shippingrates.fetch") return res.status(200).end();

Shouldn't shippingrates.fetch be taxes.calculate ?

cardof commented 1 year ago

Hey there,

In the /api/snipcart/tax endpoint there is a line which goes

if (eventName !== "shippingrates.fetch") return res.status(200).end();

Shouldn't shippingrates.fetch be taxes.calculate ?

yes you are right!!

notrab commented 1 year ago

I'd happily accept a PR

luisalrp commented 1 year ago

Hey frens!

It is not calculating the taxes using retail prices, right?