search

notrab / react-use-cart

React hook library for managing cart state
http://npm.im/react-use-cart
Apache License 2.0
367 stars 48 forks source link

Improved CI process #63

Closed ynnoj closed 3 years ago

ynnoj commented 3 years ago

Appears that yarn test is only ran as part of the release workflow against the default branches (main, beta).

We should introduce CI for all PRs to ensure:

We can use on.pull_request with a separate workflow file to build and test the package.

ynnoj commented 3 years ago

@notrab Are you happy for me to draft a PR for this?

notrab commented 3 years ago

@ynnoj yep! PR and merge at will.

Here's what I had previously https://github.com/notrab/react-use-cart/pull/56/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88 which (could be improved?) and it was mistakenly removed 🙈

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 1.11.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: