notree-md / notree

Share your knowledge
MIT License
2 stars 1 forks source link

i26: review pr 30 #31

Closed jollyjerr closed 1 year ago

jollyjerr commented 1 year ago

What does this PR do?

This PR is my review for #30

I gotta be honest, my monkey brain cannot totally comprehend everything going on in #30. It works perfectly and we can still totally go in that direction, but I'm a little overwhelmed by the complexity and I thought it was super interesting that https://github.com/jollyjerr/mindgraph/commit/7c2b2175122ba9f07e4f7c2f05d1042d3ea4f20f#diff-1b6ad78e77b4b2649a857d61600007964174ba5ee1a6d0b69517fd3b9c27e151R113 was literally SOOOO close to working so I tried to rebuild from that initial approach and see if we could avoid all the overhead logic. This is what I ended up coming up with and I'm curious what you think about the approach.

I basically made the "purgatory" that you mentioned into an actual layer (we can rename it obviously but I thought it was funny) and then saved "I was recently active" on each renderable itself so the artist could place them in purgatory. Purgatory just stays in a natural state while the base layer animates as you initially had.

Let me know what you think!

https://github.com/jollyjerr/mindgraph/assets/51095001/ec0aab12-79c8-4219-9b1c-bff419dd63eb

How does this PR make you feel? :link:

jollyjerr commented 1 year ago
Screenshot 2023-07-09 at 4 00 48 PM