Closed Jamjardavies closed 11 years ago
To make it more maintainable in the future, use the _writecmd and _writedata macros instead of ssd1351fb_writeCmd/Data. They do the same. Macro definition: https://github.com/notro/fbtft/blob/master/fbtft.h#L122 Default write_data_command() function: https://github.com/notro/fbtft/blob/master/fbtft-bus.c#L85
What's the reason for providing you're own reset() function? Is the low period of the default one too short? https://github.com/notro/fbtft/blob/master/fbtft-core.c#L285
You should also provide a verify_gpios() function to make sure 'dc' is set. This will inform the user that something vital is missing: https://github.com/notro/fbtft/blob/master/sainsmart18fb.c#L140
Hi notro,
Sorry, didn't know about the write commands/data, I followed someone elses code and they had that there too.
I will make these changes now and edit my post,
With reset, I wasn't sure on the delay, and the SSD1351 has to be set to reset for at least a set time, so I wanted to be sure.
I will also add the verify_gpios.
Would there be an update kernel with the new drivers implemented as I would like to direct the users of our displays to this?
EDIT: I have now made the changes, and tested. All seems to be working nicely! Thanks for the info!
Good, I have comitted the driver: https://github.com/notro/fbtft/commit/267969a28b566929f7e2e2bf15ccf0ef220fdf6f
Would there be an update kernel with the new drivers implemented as I would like to direct the users of our displays to this?
Sorry, not for at a couple of weeeks at least. The release process with it's testing takes quite some time. In the meantime you could provide you're own image, the process is documented here: https://github.com/notro/fbtft/wiki/FBTFT-image-build-process
I have added the display to: https://github.com/notro/fbtft/wiki/LCD-Modules Feel free to update it (everyone with a github account can). It would be nice if you measured the Frames Per Second and updated the FBTFT drivers table See note under the table for how to do it.
Hi Notro,
Thanks for the update! I've now done the test and put the FPS in the table. During video playback it gets 62 FPS (some drops to 52) which I never thought it could get, so great library!
Any thought about handling 18-bit colour? Our display is capable of drawing in 262k colours, but at present I see this library can only do 65k?
In regards to the image build, we're not in a massive rush as we won't be receiving the manufactured product for at least a week, and then we have to ship them.
If you would like to test out the driver with the display, we could ship you one out free of charge as a thank-you for allowing us to use this driver for the display?
If you would like to contact me, my email address is: jamjar@ilsoft.co.uk.
Kind regards
James
Any thought about handling 18-bit colour? Our display is capable of drawing in 262k colours, but at present I see this library can only do 65k?
The main reason I haven't done 18bpp is bandwidth. RGB565 is 2 bytes and RGB666 is 3 bytes per transferred pixel. This becomes a performance problem for all FBTFT supported SPI displays above 2 inches.
If you would like to test out the driver with the display, we could ship you one out free of charge as a thank-you for allowing us to use this driver for the display?
Yes, please do. Having the display for testing prevents me from accidentally breaking the driver with future code changes. I''l drop you an email.
This is the driver for the SSD1351 chipset.
These displays and shields can currently be pre-ordered from ILSoft as we've just been kickstarted and waiting for the manufacturing.
And for the fbtft_device.c. This is to work with the Pi Shield.
And finally the Kconfig