notro / fbtft

Linux Framebuffer drivers for small TFT LCD display modules. Development has moved to https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/fbtft?h=staging-testing
1.85k stars 493 forks source link

support for ssd_1305 #594

Closed anshulmakkar closed 1 year ago

anshulmakkar commented 1 year ago

I couldn't find the driver for ssd1305. Has its support been dropped ?

notro commented 1 year ago

It's in mainline Linux: https://elixir.bootlin.com/linux/latest/source/drivers/staging/fbtft/fb_ssd1305.c

anshulmakkar commented 1 year ago

got you. thanks.. Won't it be useful to have the following initialization for CS and DS line in the init function:

+++ b/drivers/staging/fbtft/fb_ssd1305.c
@@ -43,6 +43,8 @@ static int init_display(struct fbtft_par *par)
                mutex_unlock(&par->gamma.lock);
        }

+       par->gpio.reset = 1;
+       par->gpio.dc = 0;
        /* Set Display OFF */
        write_reg(par, 0xAE);
notro commented 1 year ago

'reset' and 'dc' are pointers to struct gpio_desc so this won't work (struct fbtft_par).

Why do you want to do this?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

anshulmakkar commented 1 year ago

The issue can be closed.