notro / tinydrm

Discontinued. Out of tree tinydrm modules
https://github.com/notro/tinydrm/wiki
99 stars 27 forks source link

ST7789 Overlay & Driver #19

Closed EliasKotlyar closed 4 years ago

notro commented 4 years ago

In fbtft we use the controller name in the Device Tree compatible string. This is misleading because these complex controllers need setup to match the panel, so now we use the display/panel name instead. So nowadays each new display gets it's own enable() function and an entry in the of_device_id table.

So which display does this setup match? In the driver you use both st7789r and st7789vw, can we just use st7789 instead?

I can fixup this when I apply unless you want to do it yourself.

EliasKotlyar commented 4 years ago

Hello @notro ,

My hardware is a no-name display with a ST7789VW controller. It can be found on Aliexpress under the term "1.3 Inch TFT Display". Unfortunately, there is not much more info regarding this. However i stumbled accross following module which seems to be nearly identical besides having a different PCB: https://www.waveshare.com/wiki/1.3inch_LCD_HAT

I have corrected my code, so hopefully it will fit now. I cannot say for sure if its compatible with a ST7789(without VW), but i suppose its easy to adjust. Only the init-code needs to be changed.

notro commented 4 years ago

Had to fix a missing array termination when hooking the driver up to Kbuild: https://github.com/notro/tinydrm/commit/d5079aebeb2e2f76036c45bf9a12629f50429788