nots1dd / Hydraware

A cross-platform solution toward a more hydro-knolwedgable world. Made for GDSC Solutions Challenge 2024
https://youtu.be/bOwJnVndX2Y
MIT License
5 stars 1 forks source link

Bugfix: RegEx implementation for authservice #2

Closed nots1dd closed 8 months ago

nots1dd commented 8 months ago

While registering, implement RE into the controller such that only popular domains can be used: For example --> @gmail.com, @outlook.com, @yahoo.com and so on. Right now, the issue is the fact that firebase authservice only checks for @ and .com in the mail ID textfield. As a result, even an arbitrary login ID such as testing@testinger.com can login despite invalid domain. This rises from the fact that I had to disable email enumeration in Firebase Console in order for changes to reflect. This is very solvable. Also create a return Dialog in case the above RE criteria is not met (you can look at the code for invalidAuth void function to mimic similar Dialog prompt behaviour.

nots1dd commented 8 months ago

Fixed by Sid on 13th Feb