UI refactor, rebuild the user settings page

[GrayHatter]

todo

• [x] audio settings
• [x] normalize the page height
• [x] make the tabs look more like tabs (look into how utox draws the backgrounds)
• [x] #542
• [x] revision tick

[GrayHatter]

closes #904

[GrayHatter]

todo fix #542 as well

[stal888]

Doesn't break anything here. :+1:

e: patch to add the git tag to cocoa makefile

diff --git a/cocoa/Makefile b/cocoa/Makefile
index c0b6431..0d70bf6 100644
--- a/cocoa/Makefile
+++ b/cocoa/Makefile
@@ -27,6 +27,8 @@ PREFIX ?= /usr/local

 SRC = $(wildcard *.c cocoa/*.m)
 OBJ = $(SRC:=.o)
+GIT_V = $(shell git describe --abbrev=8 --dirty --always --tags)
+CFLAGS += -DGIT_VERSION=\"$(GIT_V)\"

 all: utox

[GrayHatter]

@irungentoo

[towlie]

@GrayHatter Also I recommend to fix these overflow issue in a better way in general (maybe using per language spaces? or automatically detect needed space?) Because this is a big issue that uTox has accross languages when new things are added.

[GrayHatter]

The problem with using per language sizing is that first, there's no great way to decide how long a string is going to be. And when trying to size these tabs, getting overflow will become a huge problem. Even with the english text, if you narrow the window enough you lose tabs...

I don't know what a good solution for this is while still making it look good

[tsudoko]

@GrayHatter couldn't drawtextwidth()/drawtextrange() be used for tab text as a workaround?

[irungentoo]

Can you make your menu buttons change colour on mouse hover and make it switch when you click on the button (right now it only switches if you click on the text).

Clicking your name and status doesn't switch you to where you can change it.

In the Audio/Video the filter audio setting can be moved closer to the Ringtone setting.

Scrolling up and down in a setting makes the line on top disappear.

[GrayHatter]

• [x] name and status switch now
• [x] av filter audio moved
• [x] fix line scroll bug
• [x] embegen button area, highlight on mouse over

[GrayHatter]

this next commit is optional, it shrinks the wasted space in the header for settings...

[towlie]

@GrayHatter "language" is in the profile tab it belongs to "user interface". Also the close to tray button should be moved a lot more to the right because some translations are really long. I think you should check all translations to prevent further issues.

[tsudoko]

Does the "uTox Settings" label actually need to be there? Seems like it'd look fine without it.

[GrayHatter]

@GrayHatter "language" is in the profile tab it belongs to "user interface".

I thought about that, but I left it in profile because I wanted it to be front and center so to speak in case you don't speak/read english.

[GrayHatter]

Does the "uTox Settings" label actually need to be there? Seems like it'd look fine without it.

It's there for legacy reasons, but I don't know what to put there? Expanding the tabs to 30px seems like overkill.

[tsudoko]

Does it look bad with tabs at their current height, but without the settings label?

[tsudoko]

Also I'm not sure if the last tab should be so long, it looks a bit weird with a wide window and the last tab selected.

[GrayHatter]

Also I'm not sure if the last tab should be so long, it looks a bit weird with a wide window and the last tab selected.

I could make them floating widths, but they'd look equally as bad center justified for huge window widths.

[stal888]

You don't have to make the tabs 30px tall, just move everything up