Pending transfers to offline friends can't be cancelled

tsudoko commented 9 years ago

Steps to reproduce:

Start a transfer
Wait for the friend to come offline

GrayHatter commented 8 years ago

@tsudoko what's the error message from the debug output?

tsudoko commented 8 years ago

I don't think there was any, but I'll check it when I get home

tsudoko commented 8 years ago

Widget text: "File transfer broken" After clicking the 'x' button:

FileTransfer:   Toxcore doesn't like us! (6 & 0)
FileTransfer:   Unable to send command, Friend (0) offline!

Another friend:

FileTransfer:   Toxcore doesn't like us! (26 & 0)
FileTransfer:   Unable to send command, Friend (0) offline!

FT widget gets duplicated after the friend comes online, clicking 'x' on the original one will cancel the new one. The transfer works like expected when the receiver accepts it after coming back online.

GrayHatter/uTox@2919226fd219751a456450be744dadc885edd99

GrayHatter commented 8 years ago

would you rather it auto switch to a paused state?

I'm not sure how I feel about that UX for the receiver

thoughts?

On Tue, Oct 20, 2015 at 1:24 PM, tsudoko notifications@github.com wrote:

Widget text: "File transfer broken" After clicking the 'x' button:

FileTransfer: Toxcore doesn't like us! (6 & 0) FileTransfer: Unable to send command, Friend (0) offline!

Another friend:

FileTransfer: Toxcore doesn't like us! (26 & 0) FileTransfer: Unable to send command, Friend (0) offline!

FT widget gets duplicated after the friend comes online, clicking 'x' on the original one will cancel the new one. The transfer works like expected when the receiver accepts it after coming back online.

GrayHatter/uTox@2919226 https://github.com/GrayHatter/uTox/commit/2919226fd219751a456450be744dadc885edd99

— Reply to this email directly or view it on GitHub https://github.com/notsecure/uTox/issues/1063#issuecomment-149691736.

tsudoko commented 8 years ago

Two things I don't like about the current way:

when a friend goes offline, the transfer gets uncancellable and will be resubmitted after the friend is back online (the second part is fine, I just want to be able to cancel it before that happens)
after going back online a separate FT widget is created

GrayHatter commented 8 years ago

@tsudoko is this still broken with the new UI?

if so I need to add this to my repo

tsudoko commented 8 years ago

Seems to be fine now

notsecure / uTox

Pending transfers to offline friends can't be cancelled #1063