better positioning of localized strings depending on their width

notsecure / uTox

Lightweight Tox client

utox.org

GNU General Public License v3.0

597 stars 149 forks source link

better positioning of localized strings depending on their width #1084

Closed slr closed 9 years ago

slr commented 9 years ago

GrayHatter commented 9 years ago

can you rename x2 to something descriptive?

slr commented 9 years ago

I definitely can. now it's x_right_edge, hope you like it.

I thought it's common practice in drawing of boxes to name them like that:

box(int x1, int y1, int x2, int y2)

GrayHatter commented 9 years ago

common practice, but still wrong... This is perfect! Thanks

I'll merge this once I get a chance to test it.

GrayHatter commented 9 years ago

@slr I never got your strings to line up correctly, there was always a little error rate on the sizes... so I added a precompiler function to do that job here https://github.com/GrayHatter/uTox/tree/slr-fix-localization-settings

slr commented 9 years ago

great!

there was issue with bad sizes of tabs after changing of DPI. I've fixed that and other misc things.

GrayHatter commented 9 years ago

@slr I haven't forgotten about this. It'll get merged in, but right now I'm working on a refactor of the UI code in general. So once that get's done I can dive back into this.

GrayHatter commented 9 years ago

@slr thank you for your patience I merged in the current master into the above branch. If you could pull that down into your branch and fix the last two mis alignments ( the git v tag, and and the UI start in tray string and dropdown) This can get merged

Again, thanks for writing most of this!

slr commented 9 years ago

hey! I'm sorry for no responce, no problem with that. have you tried my last commit? that two misalignments is already fixed. and no, thank you.

GrayHatter commented 9 years ago

Assuming I get home at a reasonable time, I'll try to merge this tonight

GrayHatter commented 9 years ago

@slr I hate to do this to you, but I need you to rebase off master for this one...

slr commented 9 years ago

anything you want.

GrayHatter commented 9 years ago

merged into develop @tsudoko

GrayHatter commented 9 years ago

@slr this is already pulled into develop in my branch, so I'm going to close this one here. Thanks @slr this is super awesome!

slr commented 9 years ago

@GrayHatter just don't stop on bringing the awesome!