Set video window style mask to resizable on OS X.

notsecure / uTox

Lightweight Tox client

utox.org

GNU General Public License v3.0

597 stars 149 forks source link

Set video window style mask to resizable on OS X. #1132

Closed spacecowgirl314 closed 8 years ago

spacecowgirl314 commented 8 years ago

I believe the style mask lacking the resizable option was in error so I'm submitting a pull request to correct it.

stal888 commented 8 years ago

A couple of things here:

Are you sure you want to allow free-resizing? I think setting the contentAspectRatio would be more user-friendly.
GitHub says video.m's permissions were changed to 755. Please set them back to 644.

After fixing/ignoring my advice, please rebase upon grayhatter/uTox develop branch and submit this PR there; that is where current uTox dev is happening. You can tell him I said :+1:.

GrayHatter commented 8 years ago

@hachidorii any update on this? See @stal888's comment?

spacecowgirl314 commented 8 years ago

Been busy with a couple of other things and the last time I tried to change the aspect ratio it didn't work just quite right. It seemed off.

GrayHatter commented 8 years ago

@stal888 close or try to merge?

stal888 commented 8 years ago

@GrayHatter what does windows do?