search

notshi / d-preview

Generate a private d-preview site with IATI xml.
http://d-preview.codeforiati.org
1 stars 0 forks source link

IATI identifier is a link to the live site #5

Closed stevieflow closed 3 years ago

stevieflow commented 3 years ago

On preview sites, the IATI identifier is still a link

d-portal (45)

but this is a link to the live d-portal, and so would not work in many previews. When it does work in previews, it would also be confusing to the user.

I would recommend that this is just printed on screen, without being a link

(NB: this function is very useful on live d-portal btw!)

xriss commented 3 years ago

All links should now stay inside the instanced site rather than link out to the live site.

So will either work as expected within the current uploaded data or fail, this should also deal with #4 and #6

I think this is everywhere but let me know if you find a link that escapes from the sandbox.

stevieflow commented 3 years ago

Thanks @xriss

I noticed that the link to the Data Logs and IATI Registry are changed, but in either case - would not work in the preview. Ill update the #4