Errors from included file shown as part of parsed file

notskm / vscode-clang-tidy

MIT License

49 stars 25 forks source link

Errors from included file shown as part of parsed file #29

Closed frkd-dev closed 4 years ago

frkd-dev commented 4 years ago

Description When parsing clang-tidy output for .cpp files, the extension doesn't distinguish errors from included files and shows them as part of linted/opened file.

Consider two files main.hpp and main.cpp. The main.hpp includes non-existing included.hpp and clang-tidy shows the error properly:

But now if I'll open main.cpp I'll see the same error at an unexpected place:

Expected behavior The extension needs to filter out errors not related to an opened file.

notskm commented 4 years ago

Thank you for the pull request. I appreciate the help.

frkd-dev commented 4 years ago

👍 Looking forward to the next release as this issue along with #21 is making life hard.

notskm commented 4 years ago

Sorry about that! This was a very quick and dirty plugin and I ended up not having the time to improve it.

I'm starting to work on this a little bit every weekday now so I can get some of these bugs fixed. I'm going to aim for a release by Friday.

frkd-dev commented 4 years ago

Thank you for your efforts and your time. We appreciate them as well!