search

notslang / editorconfig-tools

Tools for verifying/fixing code style based on an EditorConfig file
https://npmjs.com/package/editorconfig-tools
GNU General Public License v3.0
54 stars 6 forks source link

fails when given a lot of files #1

Open notslang opened 10 years ago

notslang commented 10 years ago

it seems that the editorconfig package reads the .editorconfig file every time it is queried, so even with graceful-fs, being used in our package, the editorconfig package goes over the limit of the maximum number of files to read at once.

jednano commented 9 years ago

It sounds like the nature of the tool to me, because you can have many .editorconfig files in a project. I don't see any way to fix it. Might be a wontfix.

notslang commented 9 years ago

It might be a wontfix in this package, but it should be very simple to fix in the editorconfig package, just by doing some caching. It might need to be implemented as a special bulk resolver function, so caching doesn't cause issues in the rare case that an .editorconfig file is actually supposed to change between calls, but it should be totally doable.

jednano commented 9 years ago

Yeah. That sounds fixable. The issue should be opened there.