nottinghamtec / PyRIGS

📅 A Django-based event booking system designed for use by TEC PA and Lighting, a 'Student Run Service' of the University of Nottingham Students Union
https://nottinghamtec.co.uk/
Other
24 stars 8 forks source link

404 Error when trying to view the training record of someone who's account has been suspended due to inactivity #535

Open jerbzz opened 1 year ago

jerbzz commented 1 year ago

https://rigs.nottinghamtec.co.uk/training/item/56/qualified_users/

All names are hyperlinks.

Following the link behind my name takes me to my training record, as expected: https://rigs.nottinghamtec.co.uk/training/trainee/72/

Following any other link should also take me to that person's training record: https://rigs.nottinghamtec.co.uk/training/trainee/81/

But this link gives me a 404.

I would expect either a 403, a permission denied message, or the user profile to open. Theoretically the latter as I have a high permission level.

FreneticScribbler commented 1 year ago

I don't think it's everyone. I inadvertently introduced this anti-feature when I made people's accounts get auto suspended after a year of not logging in, ala the forum and as a vague precursor to GDPR things. It'll 404 for anyone who's been suspended, and work fine for others. Try clicking on my name, for example - that should work fine.

It should indeed open the profile for anyone, I just need to figure out how to ensure that's still possible for suspended accounts. (The vast majority of them...)

jerbzz commented 1 year ago

Makes sense that I clicked on a bunch of oldiewonks :D

On Tue, 16 May 2023 at 11:16, Arona Jones @.***> wrote:

I don't think it's everyone. I inadvertently introduced this anti-feature when I made people's accounts get auto suspended after a year of not logging in, ala the forum and as a precursor to GDPR things. It'll 404 for anyone who's been suspended, and work fine for others. Try clicking on my name, for example - that should work fine.

It should indeed open the profile for anyone, I just need to figure out how to ensure that's still possible for suspended accounts.

— Reply to this email directly, view it on GitHub https://github.com/nottinghamtec/PyRIGS/issues/535#issuecomment-1549387783, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGZ77JFYLMGVPU3AELW5RGLXGNHWNANCNFSM6AAAAAAYDDA27Q . You are receiving this because you authored the thread.Message ID: @.***>

-- James Herbert 07779 358514