search

nottombrown / rl-teacher

Code for Deep RL from Human Preferences [Christiano et al]. Plus a webapp for collecting human feedback
MIT License
556 stars 93 forks source link

Support Mujoco version 1.5 #31

Open gautam1858 opened 6 years ago

gautam1858 commented 6 years ago

Can we have this in Mujoco 1.5 version please ? Because the new MacBook Pro doesn't support 1.3 version

nottombrown commented 6 years ago

I'd be happy to accept PRs that allow Mujoco 1.5

gautam1858 commented 6 years ago

Sure and can you give me some advice on how to transform this code so as to support 1.5 version

nottombrown commented 6 years ago

I haven't looked into it yet, and don't have version 1.5, so I'm not likely to be very helpful. On Mon, Aug 7, 2017 at 9:05 PM Gautam notifications@github.com wrote:

Sure and can you give me some advice on how to transform this code so as to support 1.5 version

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nottombrown/rl-teacher/issues/31#issuecomment-320844387, or mute the thread https://github.com/notifications/unsubscribe-auth/AASt33iYTCwmxlsc1kh54SmTPRH3GKTGks5sV955gaJpZM4OuabR .

--

I enjoy constructive feedback. If you have anything you'd like to tell me anonymously, you can post it here: http://www.admonymous.com/tom

gautam1858 commented 6 years ago

Ok

jmeyers44 commented 6 years ago

The error I get using 1.5 (full trace below) implies that the Mujoco error is being thrown from the gym dependency, specifically imported on line 5 of envs.py. Therefore, I would think support for 1.5 in rl-teacher would be blocked by the upgrade to 1.5 in Gym (tracked here).

Does that sound correct @nottombrown?

Traceback (most recent call last): File "rl_teacher/teach.py", line 13, in <module> from rl_teacher.comparison_collectors import SyntheticComparisonCollector, HumanComparisonCollector File "/Users/jonathanmeyers/Dev/ml/open_ai/rl-teacher/rl_teacher/comparison_collectors.py", line 8, in <module> from rl_teacher.envs import make_with_torque_removed File "/Users/jonathanmeyers/Dev/ml/open_ai/rl-teacher/rl_teacher/envs.py", line 5, in <module> from gym.envs import mujoco File "/Users/jonathanmeyers/anaconda2/envs/rl-teacher/lib/python3.5/site-packages/gym/envs/mujoco/__init__.py", line 1, in <module> from gym.envs.mujoco.mujoco_env import MujocoEnv File "/Users/jonathanmeyers/anaconda2/envs/rl-teacher/lib/python3.5/site-packages/gym/envs/mujoco/mujoco_env.py", line 11, in <module> import mujoco_py File "/Users/jonathanmeyers/anaconda2/envs/rl-teacher/lib/python3.5/site-packages/mujoco_py/__init__.py", line 2, in <module> init_config() File "/Users/jonathanmeyers/anaconda2/envs/rl-teacher/lib/python3.5/site-packages/mujoco_py/config.py", line 37, in init_config raise error.MujocoDependencyError('Found your MuJoCo license key but not binaries. Please put your binaries into ~/.mujoco/mjpro131 or set MUJOCO_PY_MJPRO_PATH. Follow the instructions on https://github.com/openai/mujoco-py for setup.')

nottombrown commented 6 years ago

That sounds right. I'd support a PR that upgrades to the latest gym and mujoco-py On Tue, Aug 8, 2017 at 11:00 AM Jonathan Meyers notifications@github.com wrote:

The error I get using 1.5 (full trace below) implies that the Mujoco error is being thrown from the gym dependency, specifically imported on line 5 of envs.py https://github.com/nottombrown/rl-teacher/blob/master/rl_teacher/envs.py. Therefore, I would think support for 1.5 in rl-teacher would be blocked by the upgrade to 1.5 in Gym (tracked here https://github.com/openai/gym/issues/638).

Does that sound correct @nottombrown https://github.com/nottombrown?

Traceback (most recent call last): File "rl_teacher/teach.py", line 13, in

from rl_teacher.comparison_collectors import SyntheticComparisonCollector, HumanComparisonCollector File "/Users/jonathanmeyers/Dev/ml/open_ai/rl-teacher/rl_teacher/comparison_collectors.py", line 8, in from rl_teacher.envs import make_with_torque_removed File "/Users/jonathanmeyers/Dev/ml/open_ai/rl-teacher/rl_teacher/envs.py", line 5, in from gym.envs import mujoco File "/Users/jonathanmeyers/anaconda2/envs/rl-teacher/lib/python3.5/site-packages/gym/envs/mujoco/__init__.py", line 1, in from gym.envs.mujoco.mujoco_env import MujocoEnv File "/Users/jonathanmeyers/anaconda2/envs/rl-teacher/lib/python3.5/site-packages/gym/envs/mujoco/mujoco_env.py", line 11, in import mujoco_py File "/Users/jonathanmeyers/anaconda2/envs/rl-teacher/lib/python3.5/site-packages/mujoco_py/__init__.py", line 2, in init_config() File "/Users/jonathanmeyers/anaconda2/envs/rl-teacher/lib/python3.5/site-packages/mujoco_py/config.py", line 37, in init_config raise error.MujocoDependencyError('Found your MuJoCo license key but not binaries. Please put your binaries into ~/.mujoco/mjpro131 or set MUJOCO_PY_MJPRO_PATH. Follow the instructions on https://github.com/openai/mujoco-py for setup.') — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread . --

I enjoy constructive feedback. If you have anything you'd like to tell me anonymously, you can post it here: http://www.admonymous.com/tom