search

nottombrown / rl-teacher

Code for Deep RL from Human Preferences [Christiano et al]. Plus a webapp for collecting human feedback
MIT License
556 stars 93 forks source link

WebApp blank, Incorrect ACL setting for Google Cloud Bucket #37

Closed mixuala closed 6 years ago

mixuala commented 6 years ago

I followed the install/usage script closely and was able to get the demo to work. However, I had a problem with ACLs for the videos uploaded to Google Cloud

I used these commands to create my GCS Bucket

export RL_TEACHER_GCS_BUCKET="gs://rl-teacher-<YOUR_NAME>"
gsutil mb $RL_TEACHER_GCS_BUCKET
gsutil defacl ch -u AllUsers:R $RL_TEACHER_GCS_BUCKET

But the files in the bucket were not accessible to AllUsers. The human-feedback-api webapp would only display blanks where the videos were to appear. I went back and ran this command to allow AllUsers:R

gsutil acl ch -u AllUsers:R $RL_TEACHER_GCS_BUCKET
nottombrown commented 6 years ago

Interesting. Does this resolve #36 ? If so, please make a PR to update the README with the correct commands. Thanks!

mixuala commented 6 years ago

It's the opposite, https://github.com/nottombrown/rl-teacher/issues/36, resolves this bug. Perhaps the GCP bucket error message was not accurate