search

notwaldorf / cat-dns

:computer::cat: A DNS server that resolves everything to cats.
http://meowni.ca/posts/go-cat-dns-go/
MIT License
203 stars 23 forks source link

RFC conformity and label compression for cat-dns #8

Closed colmmacc closed 10 years ago

colmmacc commented 10 years ago

This change addresses https://github.com/notwaldorf/cat-dns/issues/4, https://github.com/notwaldorf/cat-dns/issues/5 and https://github.com/notwaldorf/cat-dns/issues/6 .

With these changes, cat-dns now includes the original question, works with EDNS0 options (try dig +bufsize=4096 www.example.com @localhost) and makes the answer name a compressed pointer to the query name.

notwaldorf commented 10 years ago

Hmm, so I'm not entirely sure why, but if I patch in your changes and run the server, www.google.com will get resolved to 54.197.244.191 as it should, imgur.com loads, but doing a GET on any of the imgur images 404s (for example, http://i.imgur.com/pZqZUJM.jpg). So you don't get any more cats :(

colmmacc commented 10 years ago

Good catch, fixed with https://github.com/colmmacc/cat-dns/commit/f360667813720aedc47bd745dda246ce99e6a04d

notwaldorf commented 10 years ago

Woohoo! :cat::cat::cat: Cats around the world are happy to be RFC compliant :)