search

nougad / velux-cli

Go Client for Velux Active KIX 300
MIT License
31 stars 3 forks source link

REST interface ? #1

Open roelbroersma opened 4 years ago

roelbroersma commented 4 years ago

Hi!

First of all, I appreciate all the work you did!

Are you planning to add a rest interface (flask or something) to it? I.e. the project: Dorota980 (to control an iRobot Roomba) has been given a same sort of Rest interface, in that case a new project had been made for it called REST980. It would be best to do it in the same project, instead of having forks, etc..

~Roel

roelbroersma commented 4 years ago

Oops… my fault.. I didn't saw you already had a Swagger spec here: https://github.com/nougad/velux-cli/blob/master/swagger.yaml

roelbroersma commented 4 years ago

Then I have only 1 more wish/question: Is there already a Docker version of this? Can we include the dockerfile in the project or publish it to a DockerHub?

nougad commented 4 years ago

Hey Roel,

you can directly call Velux API if you prefer a API over the CLI. This repo is containing a CLI wrapper to make the Velux API available from the command line.

I don't see the benefit of packaging the CLI binary into Docker. It's literally a single binary. Maybe you could explain the advantages you see for Docker?

Thank you!