search

nouknouk / node-zigate

ZiGate USB-TTL module for Node.js
GNU Lesser General Public License v3.0
11 stars 3 forks source link

Shouldn't it refer to zidev.ieee instead of dev.ieee to avoid get 'ReferenceError: dev is not defined' ? #4

Closed lsteelandt closed 5 years ago

lsteelandt commented 5 years ago

https://github.com/nouknouk/node-zigate/blob/9eef0bc1e8a13d315820f0a6cef535e30e68dab8/src/coordinator/coordinator.js#L417

When the Hardware Zigate hold a device not 'known' by the coordinator object (software Zigate), the calling coordinator.queryDevices() thrown an ReferenceError: dev is not defined.

I suggest that is coming from the reference of dev.ieee instead of zidev.ieee. Am I right ?

nouknouk commented 5 years ago

You're right, there was a typo.

It has been fixed in branch dev/3.1a: https://github.com/nouknouk/node-zigate/commit/b8c2e05f9ad509b1bd1b7f54fa3d9280bd87c604

will be merged with the rest in the master branch soon.