nouman-10 / Quora-Scraper

1 stars 1 forks source link

Issues in get_questions(), while and time #1

Open excellentiam-prog opened 3 years ago

excellentiam-prog commented 3 years ago

Dear Nouman,

First of all, I would like to thank you for "Your Ultimate Guide to Building a Quora Scraper". Your publication was my first contact with selenium.

The login process and search_for_query('') work very well. There is a missing parenthesis in "while" and the "name 'time' is not defined" in the get_questions(). The places 1) https://python.plainenglish.io/your-ultimate-guide-to-building-a-quora-scraper-part-2-e185b4fc98cb 2) https://gist.github.com/nouman-10/f28ae737aa7b44bbf66799097f775f3c#file-get_questions-py 3) https://github.com/nouman-10/Quora-Scraper/blob/master/scraper/scraper.py

Regards

nouman-10 commented 3 years ago

Hello, Thank you for pointing out the issue. I hadn't included the import time in the module. I have fixed them and pushed the changes