nouraellm / Lighty

Lighty is a free open-source PHP & MVC based framework that provides a very light reusable code.
25 stars 8 forks source link

Duplicate functions in Functions.php #2

Closed AXeL-dev closed 5 years ago

AXeL-dev commented 5 years ago

It seems like all the functions are duplicated in the end of the file starting from here

https://github.com/nouraellm/Lighty/blob/a1f3070cc09384d261729ff63ebfc203d0017b1e/conf/Functions.php#L85-L96

AXeL-dev commented 5 years ago

@nouraellm i cannot reply on the conversation

Deepin Capture-écran_zone de sélection _20190507191651

So to answer you, all the functions are duplicated, the duplicates starts from line 85.

nouraellm commented 5 years ago

you can

AXeL-dev commented 5 years ago

yeah, i did, anyway see you after eating XD

nouraellm commented 5 years ago

Not duplicated, but checks if the function exists, if not it has to be created

nouraellm commented 5 years ago

xD OMG You're right xDDDDDD oh my bad dunno how it happened, however fix it or let me fix that later

AXeL-dev commented 5 years ago

you didn't get me XD see this the IP function is defined here

https://github.com/nouraellm/Lighty/blob/a1f3070cc09384d261729ff63ebfc203d0017b1e/conf/Functions.php#L1-L13

and here

https://github.com/nouraellm/Lighty/blob/a1f3070cc09384d261729ff63ebfc203d0017b1e/conf/Functions.php#L85-L96

& it's the same for all functions, they are also duplicated (maybe you did a copy & paste without paying attention).

nouraellm commented 5 years ago

yup I noticed xD as I said remove them or I will later.

AXeL-dev commented 5 years ago

To know: if you want to reference a commit in an issue just add the issue number in the commit message like so: my commit message #2

nouraellm commented 5 years ago

noted, thankies x3