search

noushadali / cleartk

Automatically exported from code.google.com/p/cleartk
0 stars 0 forks source link

Break cleartk-ml-tksvmlight => cleartk-corpus dependency #372

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently, cleartk-ml-tksvmlight depends on cleartk-corpus because the 
TreeKernel class uses org.cleartk.corpus.penntreebank.TreebankFormatParser and 
org.cleartk.syntax.constituent.util.TreebankNode. This is undesirable for 
several reasons:

* cleartk-corpus depends on cleartk-type-system, but none of the cleartk-ml-* 
modules should depend on cleartk-type-system

* Issue 245 has util.TreebankNode slated for removal.

To fix this, we probably need to put some constituency tree parsing code into 
cleartk-util. However, if we follow Issue 315, that will mean adding a jparsec 
dependency in cleartk-util, and since everything depends on cleartk-util, 
everything will pull in jparsec, even if they're not using it.

Original issue reported on code.google.com by steven.b...@gmail.com on 30 May 2013 at 5:47

GoogleCodeExporter commented 9 years ago 
We're going to move TreebankFormatParser and the TreebankNode classes to 
cleartk-util.

Original comment by steven.b...@gmail.com on 25 Jun 2013 at 5:48

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision d3389223e687.

Original comment by steven.b...@gmail.com on 25 Jun 2013 at 9:54

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision f4c5caccfc65.

Original comment by steven.b...@gmail.com on 25 Jun 2013 at 9:56

GoogleCodeExporter commented 9 years ago 
Oops. Wrong issue closed. Those commits should have closed Issue 374, not Issue 
372.

Original comment by steven.b...@gmail.com on 25 Jun 2013 at 9:58

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision da8c38d6679c.

Original comment by steven.b...@gmail.com on 25 Jun 2013 at 11:05

GoogleCodeExporter commented 9 years ago 
This involved moving a few things. In particular:

* The TreebankNode POJOs were moved to org.cleartk.util.treebank
* TreebankFormatParser was moved to org.cleartk.util.treebank
* TreebankNodeUtility moved to 
org.clearrtk.corpus.penntreebank.TreebankNodeConverter
* Several methods in the old TreebankNodeUtility were moved to 
type.TreebankNodeUtil

So there are some backwards incompatibility issues, but we decided they were 
worth it.

Original comment by steven.b...@gmail.com on 25 Jun 2013 at 11:41