noushadali / mediaserver

Automatically exported from code.google.com/p/mediaserver
0 stars 0 forks source link

Negative RTP Sequence numbers #118

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.  Since the RTP Sequence number is a randomly generated unsigned short you'll 
have to make a few calls to get this to show up

What is the expected output? What do you see instead?

Since Java can't represent unsigned shorts the method is returning an INT but 
needs to mask off the first 16 bits

What version of the product are you using? On what operating system?
2.X and 3.X

Please provide any additional information below.

changing RtpPacket.java  getSeqNumber() to the following fixes the issue:

  public int getSeqNumber() {
        return buffer.getShort(2) & 0xFFFF;
    }

Original issue reported on code.google.com by sean.hay...@bsgclearing.com on 7 Feb 2013 at 3:59

GoogleCodeExporter commented 9 years ago
Another note, this may cause issues when using the Frame.getSequenceNumber() to 
re-sequence DTMF packets since later packets have a lower sequence number

Original comment by sean.hay...@bsgclearing.com on 7 Feb 2013 at 4:02

GoogleCodeExporter commented 9 years ago
Closed by revision  c9461fe0f809

Original comment by oifa.yul...@gmail.com on 8 Feb 2013 at 6:59