Closed GoogleCodeExporter closed 9 years ago
- How long do you use the fritzbox binding?
- What's your model and firmware version?
- You are on stable or an (old) snapshot of openhab 1.2?
I had also this problem when I started using the fritzbox binding - however,
after the nightly reconnect had been commited there were no problems afterwards.
Original comment by honkton...@gmail.com
on 29 May 2013 at 11:08
The problem was a different one:
The FritzboxBinding received the events from the Fritzbox. However, the item
definition was invalid, so the FritzboxBinding had no events to publish.
Unfortunately, openHAB does not display an error message when it parses my
invalid items file.
The invalid item definition was because of an icon with a dash ("-"). The
following line works fine:
Switch Incoming_Call "Ringing" <network> (Phone) { fritzbox="inbound" }
This line is invalid because of the dash in the icon name:
Switch Incoming_Call "Ringing" <network-on> (Phone) { fritzbox="inbound" }
So you may close this ticket as invalid.
Is it intended, that openHAB does not log an error message if the items file is
invalid? And is it intended, that icon names with dashes are not working?
Regards,
Martin
Original comment by planetre...@gmail.com
on 29 May 2013 at 11:10
Hi,
> Is it intended, that openHAB does not log an error message if the items file
is invalid?
No it isn't, but it's up to the binding developer to log configuration errors
accordingly. Soo feel free to enter a new enhancement issue for that. Please
update this issue with the subsequent issue number.
> And is it intended, that icon names with dashes are not working?
no it is not! See http://code.google.com/p/openhab/issues/detail?id=311 which
is about spaces in icon names. Would be great if you'd enhance comment that
issue accordingly
Regards,
Thomas E.-E.
Original comment by teichsta
on 29 May 2013 at 11:17
Okay, I will do that. But only next week, because I am on vacation now for the
long week-end.
Original comment by planetre...@gmail.com
on 29 May 2013 at 12:52
>No it isn't, but it's up to the binding developer to log configuration errors
accordingly.
There is nothing that can be done in the binding. If the icon contains a dash
in its name, BindingConfigReader.validateItemType() and
BindingConfigReader.processBindingConfiguration() don't even get called.
I will post a comment on #331 with a better example (NTP instead of Fritzbox).
Original comment by planetre...@gmail.com
on 3 Jun 2013 at 10:00
I think you can close this issue as invalid, because this is not a problem of
the fritzbox binding.
Original comment by planetre...@gmail.com
on 16 Jun 2013 at 7:02
Original comment by kai.openhab
on 16 Jun 2013 at 7:20
Original issue reported on code.google.com by
planetre...@gmail.com
on 28 May 2013 at 2:26