search

noushadali / sipservlets

Automatically exported from code.google.com/p/sipservlets
0 stars 0 forks source link

MSS overwrites host part of Contact Header in REGISTER requests #156

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
As per JSR 289 Section 4.1.3, this seems wrong : 
"The other use of Contact is in REGISTER requests and responses, as well as 3xx 
and 485 responses. The value of Contact header fields in these messages specify 
alternate addresses for a user, and there may be more than one. These are the 
uses where SIP servlets may legitimately set Contact addresses."

It may stem from confusion later in the same section saying :

" The host component of the URI and URI Scheme are irrelevant and cannot be 
trusted to reflect the actual values that the container will be using when 
inserting a Contact header into Request or Response. The container MUST ignore 
or overwrite any host/port set on the Contact URI accessed as above. This is 
because the container is responsible for managing the actual network listen 
points and uses these to create Contact headers' host/port."

I think the former section is still prevalent as those can be alternates 
addresses so not necessarily the container's IP addresses.

Original issue reported on code.google.com by jean.deruelle on 30 Aug 2012 at 1:22

GoogleCodeExporter commented 9 years ago 
Seems 
http://code.google.com/p/mobicents/source/diff?spec=svn15894&old=15885&r=15894&f
ormat=unidiff&path=%2Ftrunk%2Fservers%2Fsip-servlets%2Fsip-servlets-impl%2Fsrc%2
Fmain%2Fjava%2Forg%2Fmobicents%2Fservlet%2Fsip%2Fmessage%2FSipServletRequestImpl
.java

Caused this regression

Original comment by jean.deruelle on 30 Aug 2012 at 1:23

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision 09173cbb99d8.

Fix + non regression test

Original comment by jean.deruelle on 30 Aug 2012 at 1:47

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision 64c74f65faa7.

Backport to TelScale branch

Fix + non regression test
(cherry picked from commit 09173cbb99d8f47dc0c0c41385302354dd97ee25)

Original comment by jean.deruelle on 30 Aug 2012 at 1:48

GoogleCodeExporter commented 9 years ago

Original comment by jean.deruelle on 30 Aug 2012 at 2:06