search

nov / fb_graph

This gem doesn't support FB Graph API v2.0+. Please use fb_graph2 gem instead.
MIT License
1.04k stars 191 forks source link

New/Modified Ads API related objects/connections and Stream #264

Closed allenhwkim closed 11 years ago

allenhwkim commented 12 years ago

. Added FbGraph::AdImage and tests. . Added FbGraph::Connections::AdImages, and modified connections to make it work (1 line added i think) . Modified FbGraph::Connections::AdCreatives and added more tests for it . Added FbGraph::Stream and tests . Added FbGraph::Connections::Streams and tests . Made changes on FbGraph::AdGroupStat to reflect newsfeed positons. . Added FbGraph::AdGroupConversionStat and tests . Added FbGraph::Connections::AdGroupConversionStats . Added FbGraph::BatchBase/ BatchRequest / BatchResponse

buildhive commented 12 years ago

Nov Matake » fb_graph #32 SUCCESS This pull request looks good (what's this?)

buildhive commented 12 years ago

Nov Matake » fb_graph #33 SUCCESS This pull request looks good (what's this?)

marktorrance commented 12 years ago

I support this pull request; I'm using the added functionality from this branch successfully

allenhwkim commented 12 years ago

If this pull request is too big, i can make a separate pull request by removing objects that may not fit to fb_graph(i.e. BatchRequests). But I need to know which objects requires rewriting.

nov commented 12 years ago

Removing BatchRequests and Stream connection would be helpful.

buildhive commented 11 years ago

Nov Matake » fb_graph #76 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Nov Matake » fb_graph #77 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Nov Matake » fb_graph #78 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Nov Matake » fb_graph #80 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Nov Matake » fb_graph #85 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Nov Matake » fb_graph #88 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Nov Matake » fb_graph #89 SUCCESS This pull request looks good (what's this?)

buildhive commented 11 years ago

Nov Matake » fb_graph #90 SUCCESS This pull request looks good (what's this?)

buildhive commented 11 years ago

Nov Matake » fb_graph #93 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Nov Matake » fb_graph #96 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Nov Matake » fb_graph #104 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Nov Matake » fb_graph #105 FAILURE Looks like there's a problem with this pull request (what's this?)