Implemented Facebook Offer GraphAPI object type. Implemented basic tests...

nov / fb_graph

This gem doesn't support FB Graph API v2.0+. Please use fb_graph2 gem instead.

MIT License

1.04k stars 191 forks source link

Implemented Facebook Offer GraphAPI object type. Implemented basic tests... #282

Closed thatpythonguy closed 11 years ago

thatpythonguy commented 11 years ago

This adds the minimum required code to use the new Facebook Offer object. More work may be needed, but trying to make you see this earlier for any feedback. Thanks!

buildhive commented 11 years ago

Nov Matake » fb_graph #79 SUCCESS This pull request looks good (what's this?)

nov commented 11 years ago

Hi,

Thanks for your pull request. I didn't notice they released offer API.

I reviewed the diff and looks good. When your "more work" finished, let me know.

ps. Since I made a separate gem for mocking Graph API response recently, making pull request with mocked JSON might be tricky. I wrote a wiki for that, but if you have any questions, please ask me. https://github.com/nov/fb_graph/wiki/Mocking-API-Calls

thatpythonguy commented 11 years ago

Thanks for the heads-up. I will review the wiki page and make the necessary changes.

buildhive commented 11 years ago

Nov Matake » fb_graph #81 FAILURE Looks like there's a problem with this pull request (what's this?)